Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade highlight.js to 10.4.1 #8881

Merged
merged 1 commit into from
Dec 17, 2020
Merged

upgrade highlight.js to 10.4.1 #8881

merged 1 commit into from
Dec 17, 2020

Conversation

amiramw
Copy link
Member

@amiramw amiramw commented Dec 17, 2020

Signed-off-by: Amiram Wingarten amiram.wingarten@sap.com

What it does

Upgrade highlight.js to 10.4.1 as it contain security fix. See https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md#version-1041-tentative

How to test

Create md file with code block highlight that has a language in it and make sure the preview pane show syntax highlighs as before.

```js
var x = 8; 
 ```

See also https://community.theia-ide.org/t/preview-highlight-help/1341/2

Review checklist

Reminder for reviewers

Signed-off-by: Amiram Wingarten <amiram.wingarten@sap.com>
@amiramw amiramw requested a review from kittaakos December 17, 2020 16:03
@vince-fugnitto vince-fugnitto added dependencies pull requests that update a dependency file preview issues related to the preview security issues related to security labels Dec 17, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the updated dependency version is license compatible 👍 :

image

@amiramw in the future, you can also perform this check based on the "documentation for new or updated dependencies", and reflect it in the pull-request description.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified 👍
Screen Shot 2020-12-17 at 17 32 02

@amiramw amiramw merged commit f6d2085 into master Dec 17, 2020
@github-actions github-actions bot added this to the 1.10.0 milestone Dec 17, 2020
@amiramw amiramw deleted the highlight branch December 17, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file preview issues related to the preview security issues related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants