Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make extension deploy command extensible #8919

Merged
merged 1 commit into from
Jan 14, 2021
Merged

make extension deploy command extensible #8919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## v1.10.0

- [plugin] added `createDeployQuickOpenItem` method to create `DeployQuickOpenItem` in order to make extension deploy command extensible [#8919] (https://github.com/eclipse-theia/theia/pull/8919)

## v1.9.0 - 16/12/2020

- [cli] updated error reporting for the `download-plugins` script [#8798](https://github.com/eclipse-theia/theia/pull/8798)
Expand Down
6 changes: 5 additions & 1 deletion packages/plugin-ext/src/main/browser/plugin-ext-deploy-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,15 @@ export class PluginExtDeployCommandService implements QuickOpenModel {
public async onType(lookFor: string, acceptor: (items: QuickOpenItem[]) => void): Promise<void> {
this.items = [];
if (lookFor || lookFor.length > 0) {
this.items.push(new DeployQuickOpenItem(lookFor, this.pluginServer, 'Deploy this plugin'));
this.items.push(this.createDeployQuickOpenItem(lookFor, 'Deploy this plugin'));
}
acceptor(this.items);
}

protected createDeployQuickOpenItem(name: string, description: string): DeployQuickOpenItem {
return new DeployQuickOpenItem(name, this.pluginServer, description);
}

}

export class DeployQuickOpenItem extends QuickOpenItem {
Expand Down