Implement vscode navigateBack, navigateForward, and navigateToLastEditLocation commands #8958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditLocation commands Signed-off-by: Daniel Ku <daniel.ku@ericsson.com>
|
With the caveat of #8955 - opening any file, no matter how it's done, whether through code navigation or workspace search, always adds the first line to the navigation stack - this works for me, and appears to be consistent with how other VSCode commands are mapped to Theia commands. 👍 |
colin-grant-work
approved these changes
Jan 17, 2021
vince-fugnitto
approved these changes
Jan 18, 2021
|
@danieltomasku do you need help with merging? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Ku daniel.ku@ericsson.com
What it does
This PR maps the VS Code commands
navigateBack,navigateForward, andnavigateToLastEditLocationto their respective Theia commands. Closes #8956How to test
Review checklist
Reminder for reviewers