Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix border for search-in-workspace replace items #9090

Conversation

slhultgren
Copy link
Contributor

What it does

Fixes border for replaced items in the Search-in-workspace feature.

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN samuel.hultgren@st.com

How to test

1, Change to high-contrast dark theme
2, Search in workspace with a replace term
3, Observe that the border is green with the patch, white without the patch.

Review checklist

Reminder for reviewers

Contributed by STMicroelectronics
Signed-off-by: Samuel HULTGREN <samuel.hultgren@st.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slhultgren thank your providing a fix for the typo 👍

I confirmed using the "high contrast" theme that everything works correctly:

master:

image

pull-request:

image


In the future we should think about adjusting the search-input, and possibly other inputs in the framework as well to support high contrast themes:

image

@vince-fugnitto vince-fugnitto added search in workspace issues related to the search-in-workspace theming issues related to theming ui/ux issues related to user interface / user experience labels Feb 19, 2021
@slhultgren
Copy link
Contributor Author

Yes, I agree, there seems to be some need of future alignment when it comes to borders on various input controls.

@vince-fugnitto vince-fugnitto merged commit c2a82d5 into eclipse-theia:master Feb 19, 2021
@paul-marechal paul-marechal added this to the 1.11.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace theming issues related to theming ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants