electron: fix 'save as...' cwd

[vince-fugnitto]

What it does

Fixes #9133

The following commit fixes the defaultPath when performing a save as... in electron. Previously, the defaultPath was incorrect leading the dialog to always open where the application started. With these changes, the dialog will open at the current location where the save as... is performed.

How to test

1. start the example-electron application
2. open a file (different sublevels to test fully)
3. perform save as...
4. confirm that the dialog is opened at the correct path, and the filename is correctly populated in the input

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[kittaakos]

Previously, the defaultPath was incorrect leading the dialog to always open where the application started.

Are you sure about this? Without your changes, it seems to me that it is a "random" folder; in fact, I see the last valid folder always whenever I open the native Save as... (on macOS)

With these changes, the dialog will open at the current location where the save as... is performed.

I can confirm this. It works as expected 👍 Thank you!

The PR title is electron: fix 'save as...' cwd. Why the change in browser? Thanks!

[vince-fugnitto]

Previously, the defaultPath was incorrect leading the dialog to always open where the application started.

Are you sure about this? Without your changes, it seems to me that it is a "random" folder; in fact, I see the last valid folder always whenever I open the native Save as... (on macOS)

At least for me on Linux whenever I performed a save as... it would open the dialog at ~/workspaces/theia/example/electron no matter the workspace - (as in the video of #9133).

With these changes, the dialog will open at the current location where the save as... is performed.

I can confirm this. It works as expected Thank you!

The PR title is electron: fix 'save as...' cwd. Why the change in browser? Thanks!

I can remove the browser change, the change was simply to remove the unnecessary if statement since folder is always defined:

theia/packages/filesystem/src/browser/file-dialog/file-dialog-service.ts

Line 86 in 794fd92

if (folder) {

[kittaakos]

I have verified the changeset with the electron app; it worked as expected.

Thank you for the fix, @vince-fugnitto!

[kittaakos]

I can remove the browser change, the change was simply to remove the unnecessary if statement since folder is always defined:

No need to remove it. Thanks!