Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9158-bug-right-click-on-explorer-throws-exception #9159

Conversation

danarad05
Copy link
Contributor

Right-click on file or folder in explorer panel throws exception

Signed-off-by: Dan Arad dan.arad@sap.com

What it does

Fixes #9158

How to test

  1. Right-click on file or folder in explorer panel - to display context menu.
  2. Check console - see no exception exists

Review checklist

Reminder for reviewers

Right-click on file or folder in explorer panel throws exception

Signed-off-by: Dan Arad <dan.arad@sap.com>
@vince-fugnitto vince-fugnitto added bug bugs found in the application navigator issues related to the navigator/explorer labels Mar 8, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the patch fixes the error, and that custom editors (cat example) still works correctly.

@amiramw amiramw merged commit 926d71f into eclipse-theia:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right click on explorer panel throws exception
3 participants