Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9145 in the problem view copy action #9160

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

Niklas-Dahlquist
Copy link
Contributor

What it does

Sets the correct owner when copying a problem from the problem view
Fixes #9145

Contributed by STMicroelectronics
Signed-off-by: Niklas DAHLQUIST niklas.dahlquist@st.com

How to test

  • Copy a problem from the problem view
  • Paste in a text editor like notepad
  • Observe that resource and owner are set to correct values (TypeScript problem in this example)
  "resource": <uri>
  "owner": "typescript"  

Review checklist

Reminder for reviewers

Previously uri was returned instead of owner

Contributed on the behalf of STMicroelectronics
Signed-off-by: Niklas DAHLQUIST <niklas.dahlquist@st.com>
@vince-fugnitto vince-fugnitto added the problems issues related to the problems widget label Mar 9, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Niklas-Dahlquist thank you for the fix, I would have liked a beginner (new contributor) to pick the issue up but that's okay 👍

@vince-fugnitto vince-fugnitto merged commit 3426e8d into eclipse-theia:master Mar 11, 2021
@Niklas-Dahlquist Niklas-Dahlquist deleted the problem_owner branch December 20, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problems issues related to the problems widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marker's uri is used in problem's copy instead of the marker's owner
2 participants