VSX: Add Toolbar Menu and Support 'Install from VSIX...' Command #9184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
reviewed
Mar 23, 2021
There was a problem hiding this comment.
I tried it, and it works as expected. 👍 Could you please address my remarks, @seantan22? Thank you!
packages/vsx-registry/src/browser/vsx-extensions-contribution.ts
Outdated
Show resolved
Hide resolved
packages/vsx-registry/src/browser/vsx-extensions-contribution.ts
Outdated
Show resolved
Hide resolved
What it does - Adds an `Install from VSIX...` command that supports installation of extensions from a locally available `.vsix` file. - Adds a '_more_' toolbar menu to the `extensions view` to which additional commands may be registered How to test 1. Visit open-vsx.org and download an extension as a `.vsix` file. 2. Open the `extensions` view. 3. Select the `_more_` menu item in the toolbar and execute the `Install from VSIX...` command. 4. Select a local `.vsix` file in the file dialog and click `Install`. 5. Confirm that the selected extension has been installed by checking the `extensions` view. Signed-off-by: seantan22 <sean.a.tan@ericsson.com>
|
@kittaakos Thanks for the feedback, I've updated the pr with your suggestions. |
kittaakos
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #7538
_more_toolbar menu to theextensions viewto which additional commands may be registered.Install from VSIX...command that supports installation of extensions from a locally available.vsixfile.How to test
.vsixfile.extensionsview._more_menu item in the toolbar and execute theInstall from VSIX...command.vsixfile in the file dialog and clickInstall.extensionsview.Review checklist
Reminder for reviewers
Signed-off-by: seantan22 sean.a.tan@ericsson.com