Support "when":"true" in 'commandPalette' menus

[alvsan09]

Adds a missing check for "true" on contributed "commandPalette" menus

Fixes: #9065

Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com

What it does

Fixes the issue described by #9065, where contributed 'commandPalette' menus including the "when" clause and set to "true"
don't get presented to the user.

How to test

In your test extension add the following commands and menus to your package.json

1. Add some commands to a test plugin e.g.

		"commands": [
			{
				"command": "Alvs-extension.dosomething-true",
				"title": "Alvs do something - true",
				"category": "Alvs"
			},
			{
				"command": "Alvs-extension.dosomething-false",
				"title": "Alvs do something - false",
				"category": "Alvs"
			},
			{
				"command": "Alvs-extension.dosomething-undefined",
				"title": "Alvs do something  - undefined",
				"category": "Alvs"
			}
		]

2. Add corresponding 'commandPalette' menus to the commands above
   e.g.

		  "menus": {
			"commandPalette": [ 
			  {
				"command": "Alvs-extension.dosomething-true",
				"when": "true"
			  },
			  {
				"command": "Alvs-extension.dosomething-false",
				"when": "false"
			  },
			  {
				"command": "Alvs-extension.dosomething-undefined"
			  }
			]
		  }

3. Display the available commands via

Ctrl-shft-P and filter by 'Alvs'

4. Before this fix you would only see one entry for 'undefined'
   After applying the fix you shall see two entries 'undefined' and 'true'

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

I confirmed using the following plugin that the commands are properly enabled based on the when context:

Command	When	Result
Hello World (True)	'true'	the command is correctly enabled
Hello World (False)	'false'	the command is correctly disabled
Hello World (Undefined)	undefined	the command is correctly enabled
Hello World (Dynamic)	editorHasSelection	the command is correctly enabled when there is a selection in the editor

---

In the future I think we can likely re-use the code from vscode/contextkey.ts to handle more advanced use-cases and contexts. If might be low effort to re-use this functionality which is core to the enablement of commands, menus and views.

[vince-fugnitto]

I confirmed that the updated changes still work correctly with the plugin:

• true
• false
• undefined
• dynamic - toggleable through editorHasSelection