Handle case of empty command id with arguments

[tsmaeder]

Signed-off-by: Thomas Mäder tmader@redhat.com

What it does

This issue fixes the case where a command is transferred that has a non-empty argument list, but an empty command id. This is supposed to fix eclipse-che/che#18921 in Eclipse Che. The case of the git plugin is not reproducible for me in plain Theia (looks like it's timing-dependent), so I made an example with code actions to reproduce the problem.

How to test

1. Add the attached vsix to a theia instance and start Theia
   prefs-explorer-0.0.1.vsix.zip
2. Open a any text file and select some text
3. You should get a code action labeled "bogus title".

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[tsmaeder]

Here's the relevant code that contributes the code action:

	function provideCodeActions(document: vscode.TextDocument, range: vscode.Range | vscode.Selection, context: vscode.CodeActionContext, token: vscode.CancellationToken): vscode.ProviderResult<(vscode.Command | vscode.CodeAction)[]> {
		const circularStruct: {
			innerValue: any;
		} = {
			innerValue: undefined
		}

		circularStruct.innerValue= circularStruct;
		
		const cmd: vscode.Command= {
			command: '',
			arguments: [circularStruct],
			title: 'bogus title',
			tooltip: 'bogus tooltip'
		};
		return [cmd];
	}

[tsmaeder]

@kittaakos @vinokurig can I get a "hallelujah" on this one?

[kittaakos]

It looks good to me. Thank you for the patch 👍

[azatsarynnyy]

FYI it breaks the downstream eclipse-che/che#19441