Substitute ~ for home directory in file dialog

[kenneth-marut-work]

What it does

Fixes #9142 by adding support for '~' character in text input field of browser's file dialog. This MR also introduces some small refactors including factoritizing LocationRenderer and making it injectable to allow for cleaner dependency management and fixes a small issue to prevent autosuggest when path does not begin with / (or ~/)

How to test

• Build this branch for browser and run
• Open a file dialog (either save/open) and click on the 'folder' icon to switch to text input mode
• Begin typing a path that starts with ~, observe that autocompletion works as expected
• Navigate to a valid path that begins with ~ by pressing enter, observe it works as expected and there are no regressions

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@kenneth-marut-work I like the idea, I just had a couple of questions:

1: we have tildify, I wonder if it can be used in such a case (or perhaps it can be refactored to be simpler like you suggested but it does handle other operating systems such as windows):

theia/packages/core/src/common/path.spec.ts

Lines 263 to 268 in f20dcac

	describe('Linux', () => {
	it('should shorten path on Linux, path starting with home', async () => {
	const path = `${linuxHome}/a/b/theia`;
	const expected = '~/a/b/theia';
	expect(Path.tildify(path, linuxHome)).eq(expected);
	});

2: what happens in the windows use-case, I believe the substitution should not occur in such a case?

[kenneth-marut-work]

@kenneth-marut-work I like the idea, I just had a couple of questions:

1: we have tildify, I wonder if it can be used in such a case (or perhaps it can be refactored to be simpler like you suggested but it does handle other operating systems such as windows):

theia/packages/core/src/common/path.spec.ts

Lines 263 to 268 in f20dcac

	describe('Linux', () => {
	it('should shorten path on Linux, path starting with home', async () => {
	const path = `${linuxHome}/a/b/theia`;
	const expected = '~/a/b/theia';
	expect(Path.tildify(path, linuxHome)).eq(expected);
	});

2: what happens in the windows use-case, I believe the substitution should not occur in such a case?

I didn't know about tildify. I'll look into it, thanks for the tip 👍

[kenneth-marut-work]

@vince-fugnitto I've made use of the tildify method and also added an 'untildify' which does the reverse operation (along with tests) and also ensured that we skip the replacement for windows. I've built and tested on both Linux and Windows and it seems to be behaving as expected.

[vince-fugnitto]

I confirmed that the changes work as expected 👍

[vince-fugnitto]

I confirmed that the behavior works as intended on Linux 👍
It might be worthwhile to also verify on a Windows machine.

[kenneth-marut-work]

I confirmed that the behavior works as intended on Linux 👍
It might be worthwhile to also verify on a Windows machine.

I did build and test on Windows and am getting the expected behavior of no substitution

[kenneth-marut-work]

I've pushed a small change to make the FileDialogTreeFiltersRenderer injectable since it seemed appropriate to update alongside the LocationListRenderer

[colin-grant-work]

Since this is a new injection, maybe use property injection instead of constructor injection? Same below.

[kenneth-marut-work]

I've refactored this a bit to utilize property injection for everything except for props and moved the remaining initialization to a postConstruct. I've also updated this for SaveFileDialog and OpenFileDialog. Let me know what you think 👍

[vince-fugnitto]

@kenneth-marut-work do we plan on merging for the release?

[kenneth-marut-work]

@kenneth-marut-work do we plan on merging for the release?

@vince-fugnitto yes that would be ideal. We'll take care of it this morning if everything looks good 👍

[colin-grant-work]

This looks good to me if there are no objections to the breaking changes. 👍