-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vscode API DebugSessionOptions
#9613
Add vscode API DebugSessionOptions
#9613
Conversation
c6c2aa4
to
3630265
Compare
f8c37b8
to
31a892d
Compare
@paul-marechal @vince-fugnitto Could you help review? |
31a892d
to
2ee44b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look very promising, I only had the chance to quickly review so far and both the code and behavior look correct. I'd like to take some additional time looking more deeply at the code and reviewing additional use-cases.
2ee44b4
to
c2677fc
Compare
b17e25d
to
12a9000
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed that the behavior works as expected:
- confirmed with the test workspace that launching multiple debug sessions works correctly, the threads display nested processes, and the output view contributes a toolbar item to select the different sessions.
- confirmed that normal debug sessions (ex: _'run mocha tests') works as before
12a9000
to
c41c93c
Compare
@msujew I believe if rebased it should fix the CI failures which have been resolved 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed last week that the changes work as intended and the behavior is aligned with vscode 👍 The code is also very clean and I have no comments.
I'll let others review if interested :)
e384884
to
11b645e
Compare
@paul-marechal @colin-grant-work any additional comments? Else I'll merge the pull-request early this week. |
11b645e
to
9353b7c
Compare
9353b7c
to
4a80a29
Compare
@vince-fugnitto Thanks for the heads-up. Rebasing done 👍 |
I'll merge the pull-request tomorrow if there are no objections 👍 |
What it does
Closes #8518
Adds the
vscode.debug.DebugSessionOptions
API to Theia. This enables the following features:compact
property will simplify the label and tree structure if possibleDebugConsoleSession
and therefore are displayed independentlyconsoleMode
property set toMergeWithParent
will continue to share their console session with each other.The changes to
DebugConsoleSession
are slightly breaking. While it's still possible to simply inject theDebugConsoleSession
directly, its tight coupling toDebugSession
makes that impractical. Instead of injecting theDebugConsoleSession
directly, aDebugConsoleSessionFactory
allows to create aDebugConsoleSession
with a providedDebugSession
.How to test
vscode-js-debug
extension is installed in Theia.Launch Program
configuration.configuration.consoleMode = undefined;
and/orconfiguration.compact = undefined;
after this line, and restart the server to test how these properties influence the debug console/view.Review checklist
Reminder for reviewers