Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to configure aasId and aasIdShort #53

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

danielpeintner
Copy link
Member

fixes #50

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.23%. Comparing base (fc146ca) to head (3b1c68c).

Files with missing lines Patch % Lines
node/aas-aid/src/asset-interfaces-description.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   65.59%   65.23%   -0.36%     
==========================================
  Files           1        1              
  Lines         558      558              
  Branches      222      224       +2     
==========================================
- Hits          366      364       -2     
  Misses        155      155              
- Partials       37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner
Copy link
Member Author

@egekorkan please take a look and let me know whether that's how you envision it to look like...

@egekorkan
Copy link
Member

@egekorkan please take a look and let me know whether that's how you envision it to look like...

Yup that is what I had in mind. Just going to confirm with another developer as well

@egekorkan
Copy link
Member

Works as expected by users, merging

@danielpeintner danielpeintner merged commit a6943fa into eclipse-thingweb:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AID] Allow giving id and idShort as parameters when converting a TD to AID
3 participants