timing: Fix SegmentStoreScatterDataProvider for empty segment store #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if a trace doesn't have any call stack events to populate the segment store and hence populate the view, the data provider should return an empty model instead of failed for fetchTree and fetchXy [Fixed] Fix SegmentStoreScatterDataProvider for empty segment store Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
fix_scatter_chart
branch
from
bb434e5 to
a63db7a
Compare
MatthewKhouzam
approved these changes
Oct 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if a trace doesn't have any call stack events to populate the segment store and hence populate the view, the data provider should return an empty model instead of failed for fetchTree and fetchXY.
[Fixed] Fix SegmentStoreScatterDataProvider for empty segment store
Note: This is bug is only visible when using the trace server and JS front-end and not in Eclipse.
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com