-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statesysten: add processSpanStateChange function to statesystem #45
Open
farajidaneshgar
wants to merge
1
commit into
eclipse-tracecompass:master
Choose a base branch
from
farajidaneshgar:openTracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -681,4 +681,19 @@ static void logMissingInterval(int attribute, long timestamp) { | |
attribute + " at time " + timestamp + //$NON-NLS-1$ | ||
", returning dummy interval"); //$NON-NLS-1$ | ||
} | ||
|
||
/** | ||
* @param t | ||
* @param value | ||
* @param attributeQuark | ||
* @param spanQuark | ||
* @throws TimeRangeException | ||
* @throws StateValueTypeException | ||
*/ | ||
@Override | ||
public void modifySpanAttribute(long t, Object value, int attributeQuark, int spanQuark) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Span is not a state system notion, it's a contextual interval. Should we bring it down to this level of abstraction? |
||
throws TimeRangeException, StateValueTypeException { | ||
transState.processSpanStateChange(t, value, attributeQuark,spanQuark); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ | |
import org.eclipse.jdt.annotation.Nullable; | ||
import org.eclipse.tracecompass.statesystem.core.exceptions.AttributeNotFoundException; | ||
import org.eclipse.tracecompass.statesystem.core.exceptions.StateSystemDisposedException; | ||
import org.eclipse.tracecompass.statesystem.core.exceptions.StateValueTypeException; | ||
import org.eclipse.tracecompass.statesystem.core.exceptions.TimeRangeException; | ||
import org.eclipse.tracecompass.statesystem.core.interval.ITmfStateInterval; | ||
import org.eclipse.tracecompass.statesystem.core.statevalue.ITmfStateValue; | ||
|
@@ -540,4 +541,15 @@ int getQuarkRelative(int startingNodeQuark, String... subPath) | |
*/ | ||
Iterable<@NonNull ITmfStateInterval> query2D(@NonNull Collection<Integer> quarks, | ||
long start, long end) throws StateSystemDisposedException, IndexOutOfBoundsException, TimeRangeException; | ||
|
||
/** | ||
* @param t | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More documentation |
||
* @param value | ||
* @param attributeQuark | ||
* @param spanQuark | ||
* @throws TimeRangeException | ||
* @throws StateValueTypeException | ||
* @since 5.4 | ||
*/ | ||
void modifySpanAttribute(long t, Object value, int attributeQuark, int spanQuark) throws TimeRangeException, StateValueTypeException; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More doc please