Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement CodeQL suggestions #1181

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jan 15, 2025

Description

This pull requests implements suggestions by the CodeQL analysis:

  • resolve possible int multiplication overflows
  • remove unnecessary toString invocations
  • replace deprecated CSV builder function

Fixes #1150

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

- resolve possible int multiplication overflows
- remove unnecessary toString invocations
- replace deprecated CSV builder function
@nicoprow nicoprow added the enhancement New feature or request label Jan 15, 2025
@nicoprow nicoprow added this to the BPDM v6.3.0 / R25.03. milestone Jan 15, 2025
@nicoprow nicoprow marked this pull request as ready for review January 15, 2025 04:48
@nicoprow nicoprow requested a review from SujitMBRDI January 15, 2025 04:48
Copy link
Contributor

@SujitMBRDI SujitMBRDI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Tests performed -
Changes are straightforward

  • All unit tests running correctly.
  • BPDM Pool - Regions inserted successfully.

@SujitMBRDI SujitMBRDI merged commit f783260 into main Jan 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: CodeQL Code Suggestions
2 participants