Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(charts): increase BPDM charts app-version to 6.0.2 #984

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

nicoprow
Copy link
Contributor

@nicoprow nicoprow commented Jul 3, 2024

Description

This pull request increases the BPDM charts app-version to 6.0.2

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@nicoprow nicoprow requested a review from SujitMBRDI July 3, 2024 07:00
@nicoprow
Copy link
Contributor Author

nicoprow commented Jul 3, 2024

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

@SujitMBRDI
Copy link
Contributor

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there.
can we go for 5.1.0 then? or do you see other option.

@nicoprow
Copy link
Contributor Author

nicoprow commented Jul 3, 2024

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there. can we go for 5.1.0 then? or do you see other option.

The workflow checks are just there to alert us of some problems that might be there in the pull request. If you can see as well that the version bump is correct and everything else about the charts is correct as well, you can approve anyway and we merge it

@SujitMBRDI
Copy link
Contributor

Linting workflow does not work correctly here as it uses the last tag in the repo instead of using the last tag on the branch to compare old and new versions.

Yeah, last and latest tag in our repo currently 5.1.0-SNAPSHOT but which is in main, we cannot bump it up from there. can we go for 5.1.0 then? or do you see other option.

The workflow checks are just there to alert us of some problems that might be there in the pull request. If you can see as well that the version bump is correct and everything else about the charts is correct as well, you can approve anyway and we merge it

Got confused as pull request is in draft state, thought merging this changes will not possible unless we fix linting checks.
For patch version, i can see version bump for app and helm chart are correct.

@nicoprow nicoprow marked this pull request as ready for review July 3, 2024 08:03
@nicoprow nicoprow merged commit 951dd4b into release/6.0.x Jul 3, 2024
3 of 4 checks passed
@nicoprow nicoprow deleted the fix/charts/appversion-6.0.2 branch July 3, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants