Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EcoPass KIT 24.08 adoption view adapted #952

Merged
merged 6 commits into from
Jul 23, 2024
Merged

EcoPass KIT 24.08 adoption view adapted #952

merged 6 commits into from
Jul 23, 2024

Conversation

catroest
Copy link
Contributor

@catroest catroest commented Jun 27, 2024 •
edited by matbmoser
Loading

Description

Please describe your PR:

  • new version numbers of models
  • passage added to highlight which shared models are used

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@catroest
adoption view changed
9315447 
- new version numbers of models
- passage added to highlight which shared models are used
@catroest catroest requested a review from matbmoser June 27, 2024 13:42
matbmoser
matbmoser approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me is fine, the latest models are public already we don't need an IP clearance here I believe

@matbmoser
Copy link
Contributor

@catroest please check the identation

matbmoser
matbmoser requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@matbmoser matbmoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identention

@catroest catroest requested a review from matbmoser June 28, 2024 09:42
@catroest catroest self-assigned this Jun 28, 2024
matbmoser
matbmoser previously approved these changes Jun 28, 2024
View reviewed changes
@matbmoser
Copy link
Contributor

I needed to update some things that were incorrect from the development view. All the things mentioned and added are already open source so no IP check is needed

matbmoser
matbmoser previously approved these changes Jul 2, 2024
View reviewed changes
@matbmoser matbmoser mentioned this pull request Jul 3, 2024
Closed
12 tasks
This was linked to issues Jul 3, 2024
[DPP] Digital Product Pass Verification Documentation Update (R24.08) eclipse-tractusx/sig-release#651
Closed
Release KIT 24.05 eclipse-tractusx/digital-product-pass#358
Closed
@matbmoser matbmoser removed a link to an issue Jul 5, 2024
Release KIT 24.05 eclipse-tractusx/digital-product-pass#358
Closed
@matbmoser matbmoser added the documentation Improvements or additions to documentation label Jul 8, 2024
@matbmoser matbmoser mentioned this pull request Jul 4, 2024
Closed
3 tasks
@matbmoser matbmoser linked an issue Jul 8, 2024 that may be closed by this pull request
[EcoPass KIT]: [Release 24.08] Updated Data Models to latest standardized versions available eclipse-tractusx/sig-release#591
Closed
3 tasks
@matbmoser matbmoser merged commit 2f19bb2 into eclipse-tractusx:main Jul 23, 2024
5 checks passed
@matbmoser matbmoser deleted the ecopasskit branch July 23, 2024 16:53
@jSchuetz88 jSchuetz88 mentioned this pull request Jul 23, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudkhan116 saudkhan116 saudkhan116 approved these changes

@matbmoser matbmoser matbmoser approved these changes

@LuisRickert LuisRickert LuisRickert approved these changes

@maximilianong maximilianong Awaiting requested review from maximilianong

@stephanbcbauer stephanbcbauer Awaiting requested review from stephanbcbauer

Assignees

@catroest catroest

Labels
documentation Improvements or additions to documentation
Projects
Digital Product Pass
Status: Done
Milestone
No milestone
4 participants
@catroest @matbmoser @LuisRickert @saudkhan116