Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong http status when Job is running #279

Closed
5 tasks done
ds-ext-kmassalski opened this issue Nov 13, 2023 · 3 comments
Closed
5 tasks done

Wrong http status when Job is running #279

ds-ext-kmassalski opened this issue Nov 13, 2023 · 3 comments
Assignees
@ds-ext-kmassalski
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code linked_to_feature Issue is linked to a feature

Comments

@ds-ext-kmassalski
Copy link
Contributor

ds-ext-kmassalski commented Nov 13, 2023 •
edited by mkanal
Loading

Description

According to documentation and swagger contract we should return 206 http status, but currently we are returning 200 when job is still running.

Hint

Tasks

  • Add INT or E2E tests covering 206 return code for incomplete results Return job with current processed item graph for the requested id.

Current behavior

200 http status is being returned

Expected behavior

Return 206 HTTP status

Image

Outcome

  • No issues could be found during QA-review.
  • IRS-job requests are responded with http code 206 as long as the desired job is in status RUNNING, independent of returnUncompletedJob settings.
  • Tavern tests are adjusted and one more created, please see PR #649.
  • Follow up ticket for adjusting the http code 206 for all other job responses has been created as discussed: Extend http status 206 to all IRS job requests #289.
    Ticket is ready for PO-review.
@ds-ext-kmassalski ds-ext-kmassalski moved this to inbox in IRS Nov 13, 2023
@ds-ext-kmassalski ds-ext-kmassalski added the bug Something isn't working label Nov 13, 2023
@mkanal mkanal moved this from inbox to next in IRS Nov 14, 2023
@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Nov 15, 2023
@ds-ext-kmassalski ds-ext-kmassalski moved this from next to wip in IRS Nov 15, 2023
@ds-ext-kmassalski ds-ext-kmassalski moved this from wip to review in IRS Nov 15, 2023
@ds-ext-kmassalski
Copy link
Contributor Author

Backend implementation is done, 206 http status is returned when job is running:
image
@ds-alexander-bulgakov please prepare tests, its deployed on DEV env

@ds-alexander-bulgakov ds-alexander-bulgakov self-assigned this Nov 16, 2023
Open
7 tasks
@ds-alexander-bulgakov
Copy link
Contributor

No issues could be found during QA-review. IRS-job requests are responsed with http code 206 as long as the desired job is in status RUNNING, independent from returnUncompletedJob settings. Tavern tests are adjusted and one more created, please see PR #649.
Follow up ticket for adjusting the http code 206 for all other job responses has been created as discussed: #289.
Ticket is ready for PO-review.

@mkanal
Copy link
Contributor

mkanal commented Nov 17, 2023

PO acceptance of behalf of @jzbmw all AC is done.

@mkanal mkanal closed this as completed Nov 17, 2023
@mkanal mkanal moved this from review to done in IRS Nov 17, 2023
@ds-ext-kmassalski ds-ext-kmassalski changed the title Wrong http status when Job is running and parameter returnUncompletedJob set to true Wrong http status when Job is running Nov 17, 2023
@ds-ext-kmassalski ds-ext-kmassalski self-assigned this Nov 20, 2023
ds-jhartmann pushed a commit that referenced this issue Nov 21, 2023
@ds-alexander-bulgakov
Merge pull request #649 from catenax-ng/feature/#279_adjust-tavern-te…
ed552e3 
…sts-to-http-206-code

feature/#279: Added and adjusted tavern tests to http code 206 for running jobs
@mkanal mkanal added github_actions Pull requests that update GitHub Actions code linked_to_feature Issue is linked to a feature labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ds-ext-kmassalski ds-ext-kmassalski

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code linked_to_feature Issue is linked to a feature
Projects
IRS
Status: done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkanal @ds-ext-kmassalski @ds-alexander-bulgakov