Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/chore/docs: SAST, trivy, charts, LEGAL INFO, CHANGELOG #20

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Aug 24, 2023

WHAT

Incorporate mitigations from static code analysis.
Improve workflows
Improve maven build to include Legal Infos
Remove redundant and wrong COPYRIGHT
CHANGELOG prepared for release

WHY

results from mitigating all SAST findings which should not be accepted.
SNAPSHOT charts should be able to find a SNAPSHOT or latest image in dockerhub.
trivy step was disabled/muted due to docker manifest check requiring a login.
maven resources where not completely covering TRG7.05
CHANGELOG needs to reflect the (upcoming) release status.

FURTHER NOTES

Closes #22

@drcgjung drcgjung changed the title fix/chore: fix/chore: SAST, trivy, charts Aug 24, 2023
@drcgjung drcgjung changed the title fix/chore: SAST, trivy, charts fix/chore: SAST, trivy, charts, LEGAL INFO Aug 25, 2023
@SebastianBezold
Copy link
Contributor

Hi @drcgjung, the changes look good to me, but could you check why the tests are failing?

@drcgjung
Copy link
Contributor Author

drcgjung commented Aug 26, 2023

Hi @drcgjung, the changes look good to me, but could you check why the tests are failing?

I puzzled over this myself. But I found it out ... We use a quite stable public SPARQL server (query.wikidata.org) to test "real" internet remoting (and security restrictions). That service seemed to be down in that very moment. Wen I tested myself short term after, it was there again. Maybe just a routing prob inside the github/MS cloud ... Never occurred before and I would only think over the test design if this happens again.

2023-08-25T16:47:32.1579905Z Caused by: org.apache.jena.atlas.web.HttpException: POST https://query.wikidata.org/sparql
...
2023-08-25T16:47:32.1663393Z Caused by: java.net.SocketException: Network is unreachable

Could you please restart the failed build? Should run through then. Thx.

@SebastianBezold
Copy link
Contributor

Ok passing after restart

@drcgjung drcgjung changed the title fix/chore: SAST, trivy, charts, LEGAL INFO fix/chore/docs: SAST, trivy, charts, LEGAL INFO, CHANGELOG Aug 26, 2023
@SebastianBezold SebastianBezold merged commit 729b547 into eclipse-tractusx:main Aug 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COPYRIGHT.md does contain wrong information
2 participants