Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig#809 - Implement permission for Onboarding Service Provider endpoints #994

Closed
3 tasks
MaximilianHauer opened this issue Sep 12, 2024 · 1 comment · Fixed by #1037
Closed
3 tasks

sig#809 - Implement permission for Onboarding Service Provider endpoints #994

MaximilianHauer opened this issue Sep 12, 2024 · 1 comment · Fixed by #1037
Assignees
Labels
enhancement New feature or request

Comments

@MaximilianHauer
Copy link

MaximilianHauer commented Sep 12, 2024

Description

The following endpoints are only reachable via the "Onboarding Service Provider Management" Page.
Therefor the permission needs to be adjusted accordingly

Adjust the following endpoint to verify against the permission configure_partner_registration

POST: api/administration/registration/network/partnerRegistration
GET: api/administration/registration/network/companies

move api/administration/registration/network/companies to network controller

api/administration/registration/network/companies -> should be moved to the network controller

Acceptance Criteria

  • Ensure that the endpoints POST: api/administration/registration/network/partnerRegistration and GET: api/administration/registration/network/companies are only accessible to users who have the configure_partner_registration permission.
  • Unauthorized access attempts should return an appropriate HTTP status code indicating lack of permission (e.g., 403 Forbidden).
  • Move the GET: api/administration/registration/network/companies endpoint from its current controller to the network controller.

Test cases

Authorized Access - POST Endpoint

Objective: Verify that a user with configure_partner_registration permission can access the POST: api/administration/registration/network/partnerRegistration endpoint.
Steps:
Authenticate as a user with configure_partner_registration permission.
Send a POST request to api/administration/registration/network/partnerRegistration.
Expected Result: The request is successful, and the server responds with a 200 OK status code.

Unauthorized Access - POST Endpoint

Objective: Ensure that a user without configure_partner_registration permission receives a 403 Forbidden status when attempting to access the POST: api/administration/registration/network/partnerRegistration endpoint.
Steps:
Authenticate as a user without configure_partner_registration permission.
Send a POST request to api/administration/registration/network/partnerRegistration.
Expected Result: The server responds with a 403 Forbidden status code.

Authorized Access - GET Endpoint

Objective: Confirm that a user with configure_partner_registration permission can access the GET: api/administration/registration/network/companies endpoint.
Steps:
Authenticate as a user with configure_partner_registration permission.
Send a GET request to api/administration/registration/network/companies.
Expected Result: The request is successful, and the server responds with a 200 OK status code.

Unauthorized Access - GET Endpoint

Objective: Verify that a user without configure_partner_registration permission receives a 403 Forbidden status when attempting to access the GET: api/administration/registration/network/companies endpoint.
Steps:
Authenticate as a user without configure_partner_registration permission.
Send a GET request to api/administration/registration/network/companies.
Expected Result: The server responds with a 403 Forbidden status code.

@MaximilianHauer MaximilianHauer added the enhancement New feature or request label Sep 12, 2024
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 12, 2024
@MaximilianHauer MaximilianHauer changed the title sig#809 - Implement Companyrole based policy-types sig#809 - Implement permission for Onboarding Service Provider endpoints Sep 12, 2024
@Phil91 Phil91 assigned Phil91 and unassigned AnuragNagpure Sep 26, 2024
Phil91 added a commit that referenced this issue Sep 26, 2024
Phil91 added a commit that referenced this issue Sep 26, 2024
ntruchsess pushed a commit that referenced this issue Oct 1, 2024
* relocate endpoint api/administration/registration/network/companies to api/administration/network/companies
* adjust permisssion from 'view_submitted_applications' to 'configure_partner_registration'
Refs: #994
@ntruchsess ntruchsess linked a pull request Oct 1, 2024 that will close this issue
8 tasks
@gopalreddy-bmw
Copy link

Hi @Phil91 , @MaximilianHauer
Tested this US According to requirements it's Working fine.
Attached screenshots for references :
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants