Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(osp): add externalID and datecreated in registration network companies api #916

Conversation

AnuragNagpure
Copy link
Contributor

@AnuragNagpure AnuragNagpure commented Aug 12, 2024

Description

Change endpoint GET /api/administration/registration/network/companies

  • Add externalID field to the response body to represent the external identifier of the company.
  • Add dateCreated field to the response body to represent the creation date of the company record.
  • Add new (optional) query-parameter externalID to facilitate lookup using external identifiers.
  • Add new (optional) query parameter dateCreatedOrderFilter (values ASC, DESC) to specify order of result.
  • Implement sorting by dateCreated in both ascending (ASC) and descending (DESC) order.

Why

The response body should include the new fields externalID and dateCreated.
The API should support query parameters for searching by companyName and externalID.
The API should support query parameters for sorting by dateCreated in both ASC and DESC order.

Issue

#850

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@MaximilianHauer MaximilianHauer added the priority PR needs to prioritized at review label Aug 12, 2024
@evegufy evegufy changed the base branch from main to release/v2.2.0-RC2 August 12, 2024 13:17
@evegufy evegufy added this to the Release 2.2.0 milestone Aug 12, 2024
@ntruchsess ntruchsess self-assigned this Aug 12, 2024
@ntruchsess ntruchsess force-pushed the feature/850-api-enhancement-osp-customer-management branch from 0a799a6 to 65f80f8 Compare August 12, 2024 14:42
Copy link

sonarcloud bot commented Aug 12, 2024

@ntruchsess ntruchsess merged commit 801050d into eclipse-tractusx:release/v2.2.0-RC2 Aug 12, 2024
14 checks passed
evegufy pushed a commit that referenced this pull request Aug 13, 2024
…panies api (#916)

change endpoint GET /api/administration/registration/network/companies
- add externalID field to the response body to represent the external identifier of the company.
- add dateCreated field to the response body to represent the creation date of the company record.
- add new (optional) query-parameter externalID to facilitate lookup using external identifiers.
- add new (optional) query parameter dateCreatedOrderFilter (values ASC, DESC) to specify order of result.
- implement sorting by dateCreated in both ascending (ASC) and descending (DESC) order.
---------
Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Status: USER READY
4 participants