fix: user role description translations in en/de #1287
+75
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@kunalgaurav-bmw @lavanya-bmw @manojava-gk please review |
8 tasks
evegufy
changed the base branch from
release/v2.3.0-RC3
to
release/v2.3.0-RC4
oyo
requested changes
Nov 13, 2024
| CSVCells[0] === 'roles;description\r' || | ||
| CSVCells[0] === 'roles;description' | ||
| CSVCells[0] === 'roles;description_en;description_de\r' || | ||
| CSVCells[0] === 'roles;description_en;description_de' |
There was a problem hiding this comment.
The implemented solution wouldn't work with more than two languages in case we provide descriptions for additional languages in the future.
| Commercial Manager;Commercial Specialist can do the final approval of commercial request and trigger the payout;Der Handelsspezialist kann die endgültige Genehmigung des Handelsantrags vornehmen und die Auszahlung veranlassen. | ||
| Recycler;Recycler can buy recycled material;Recycler können recyceltes Material kaufen | ||
| Manager;This is only a test text in EN;Das is in Deutsch |
There was a problem hiding this comment.
the translations should not appear in this template. Instead we should have them together with the other translations in src/assets/locales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the CSV file parsing journey in order to extract the German language translations for User role's description in process of App creation.
Changelog entry:
Why
we weren't handling the User Role's description in German language from CSV file template.
Issue
#1288
Checklist