Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(technical user management): enhance table with status column #967

Merged

Conversation

lavanya-bmw
Copy link
Contributor

@lavanya-bmw lavanya-bmw commented Jul 26, 2024

Description

Enhance technical user table by adding StatusTag to the status column by fetching the status from the backend
Enhance technical user table status column by adding new status 'pending deletion'

Why

To enhance technical user table by adding StatusTag to the status column
Technical user table status column is updated with new status 'pending deletion'

Issue

#944, #988

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@lavanya-bmw lavanya-bmw marked this pull request as draft July 26, 2024 06:03
@lavanya-bmw
Copy link
Contributor Author

This PR to be merged once eclipse-tractusx/portal-shared-components#249 is merged

@lavanya-bmw lavanya-bmw marked this pull request as ready for review July 26, 2024 06:33
@MaximilianHauer
Copy link

@lavanya-bmw shard-component pr is merged please proceed.

@lavanya-bmw
Copy link
Contributor Author

@lavanya-bmw shard-component pr is merged please proceed.

@oyo @kunalgaurav-bmw Can you please review this PR(this is merge ready)

@lavanya-bmw lavanya-bmw added the priority PR needs to prioritized at review label Aug 6, 2024
Copy link
Contributor

@kunalgaurav-bmw kunalgaurav-bmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine for me :)

Copy link
Contributor

@oyo oyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use types instead of strings from the beginning - this makes the code easier to understand

Copy link

sonarcloud bot commented Aug 12, 2024

@lavanya-bmw lavanya-bmw requested a review from oyo August 12, 2024 09:59
@oyo oyo merged commit 10b8fd6 into eclipse-tractusx:main Aug 12, 2024
8 checks passed
@lavanya-bmw lavanya-bmw deleted the feat/944/technical-user-management branch August 27, 2024 17:08
@MaximilianHauer MaximilianHauer added this to the Release 2.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

4 participants