Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tech user): add new operator invite tech user #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Sep 17, 2024

Description

New technical_roles_management composite role with name Registration Internal with:

  • invite_new_partner
  • view_submitted_applications

Both were previously only available for CX Admin.

Backend change: eclipse-tractusx/portal-backend#1002

Why

Operator company wants to integrate 3rd party service to send out invites. Allows inviting and reviewing status via API.

Issue

Refs: eclipse-tractusx/portal-backend#932

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

Copy link

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typecastcloud technically this looks fine, but you do not declare to have tested the change (together with portal-db-data in eclipse-tractusx/portal-backend#1002) at least locally?
@evegufy you may want to include this PRs data in your iam-tests for eclipse-tractusx/portal-backend#910

@typecastcloud typecastcloud marked this pull request as draft September 17, 2024 11:06
Copy link

sonarcloud bot commented Sep 19, 2024

@typecastcloud typecastcloud marked this pull request as ready for review September 19, 2024 09:42
@evegufy
Copy link
Contributor

evegufy commented Sep 23, 2024

eclipse-tractusx/portal-backend#1002

@ntruchsess thanks for the comment, it looks fine
@typecastcloud great that you took care of eclipse-tractusx/portal-backend#1002 as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

3 participants