Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encryptionKey): align dim and issuerComponent config #368

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jul 16, 2024

Description

Align the credential and wallet configuration to use the same encryption key

Why

The same key is used for encrypting and decryption the wallet data by different processes.

Issue

Refs: #358

Checklist

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from evegufy July 16, 2024 09:06
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be the other way around as the issuerComponent encryption key must match the dim encryption key: I mean shouldn't the dim encryption key remain, as that is the key which does and will continue doing encrypting?

@Phil91 Phil91 force-pushed the bugfix/358-encryption-key branch 3 times, most recently from e8ceba9 to 13d62ed Compare July 17, 2024 10:58
@Phil91 Phil91 requested a review from evegufy July 17, 2024 11:09
@Phil91
Copy link
Member Author

Phil91 commented Jul 17, 2024

shouldn't it be the other way around as the issuerComponent encryption key must match the dim encryption key: I mean shouldn't the dim encryption key remain, as that is the key which does and will continue doing encrypting?

adjusted

environments/helm-values/values-int.yaml Outdated Show resolved Hide resolved
@Phil91 Phil91 force-pushed the bugfix/358-encryption-key branch from 13d62ed to 4bfc7b4 Compare July 17, 2024 12:13
@Phil91 Phil91 requested a review from evegufy July 17, 2024 12:45
@evegufy evegufy requested a review from ntruchsess July 17, 2024 13:41
@evegufy evegufy merged commit 8cede8b into release-candidate Jul 17, 2024
4 checks passed
@evegufy evegufy deleted the bugfix/358-encryption-key branch July 17, 2024 15:57
evegufy added a commit that referenced this pull request Jul 17, 2024
evegufy added a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants