-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implemented material list view #732
feat: implemented material list view #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
As I missed the meetings:
- I don't see a user story in [PURIS FOSS] Enhance UI sig-release#916
- that links the material list view directly to the dashboard - is that planned?
- that implements the details view (currently placeholder)
- Please tick the review boxes in the pr if you checked it (it's meant for the PRing person)
- As the direction is derived based on partners, will that reflected somewhere in the material view?
frontend/src/features/material-list/components/MaterialList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Looks great. Please handle bruno updates.
backend/src/main/java/org/eclipse/tractusx/puris/backend/masterdata/domain/model/Material.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
0ce9b06
into
eclipse-tractusx:feat/916-enhance-ui
Description
#702
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: