feat: _addition of header_ #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adkumar1
commented
Aug 21, 2023
•
adkumar1
commented
- Added headers to the files
- Fixes chore: include FOSS files in the built artifact #60
almadigabor
requested changes
Aug 21, 2023
charts/sdfactory/values.yaml
Outdated
| @@ -32,7 +32,7 @@ image: | |||
| # -- Set the Image Pull Policy | |||
| pullPolicy: Always | |||
| # -- Image tage is defined in chart appVersion. | |||
| tag: "" | |||
| tag: "main" | |||
There was a problem hiding this comment.
We don't accept using main tag in the default values.yaml. Please revert this and use the Chart.yaml appVersion property in your template as default.
almadigabor
approved these changes
Aug 21, 2023
|
Merging as the helm workflow fails due to missing image. Although this issue should be fixed with an updated workflow that builds the image on the fly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.