Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Model mapper changes aligned with AAS 3.0 standard #177

Merged
merged 29 commits into from
Aug 4, 2023

Conversation

agg3fe
Copy link
Contributor

@agg3fe agg3fe commented Jul 25, 2023

Description

  • Changes done according to AAS 3.0 standard.
  • JPA entities and mappers are changed.
  • New models and tables are created.
  • Liquibase script has been changed.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • Copyright and license header are present on all affected files

Additional information

The PR is bigger than the expected 1000 lines because of new AAS 3.0 standard changes, which includes database changes and model changes.

bs-sili and others added 27 commits June 28, 2023 14:07
…ifier and "=null" corrected; App can run, but tests are currently failing.
…ls-to-new-API

# Conflicts:
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/mapper/ShellMapper.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/mapper/SubmodelMapper.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/Shell.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellDescription.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellDisplayName.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellIdentifier.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellKind.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/Submodel.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/SubmodelEndpoint.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/repository/ShellRepository.java
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
#	backend/src/main/resources/db/changelog/db.changelog-master.yaml
#	backend/src/main/resources/db/changelog/db.changelog-v2.yaml
#	backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiSecurityTest.java
#	backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiTest.java
#	backend/src/test/java/org/eclipse/tractusx/semantics/registry/mapper/ShellMapperTest.java
…r-changes

# Conflicts:
#	backend/src/main/java/org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java
#	backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiSecurityTest.java
#	backend/src/test/java/org/eclipse/tractusx/semantics/registry/TestUtil.java
@tunacicek tunacicek self-requested a review July 25, 2023 10:05
Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebastianBezold
Copy link

Before merging, wait for the project content review: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9749

@tunacicek
Copy link
Contributor

@SebastianBezold : do you have an update on this PR?

@SebastianBezold
Copy link

@SebastianBezold : do you have an update on this PR?

Hi @tunacicek , from my point of view the PR is fine, but the project content review linked above is still open

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@tunacicek
Copy link
Contributor

Content review is done (approved): https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9749
We will merge the PR

@tunacicek tunacicek merged commit a82688c into eclipse-tractusx:main Aug 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants