-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Model mapper changes aligned with AAS 3.0 standard #177
Feat: Model mapper changes aligned with AAS 3.0 standard #177
Conversation
…ifier and "=null" corrected; App can run, but tests are currently failing.
…ls-to-new-API # Conflicts: # backend/src/main/java/org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/mapper/ShellMapper.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/mapper/SubmodelMapper.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/Shell.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellDescription.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellDisplayName.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellIdentifier.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/ShellKind.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/Submodel.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/model/SubmodelEndpoint.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/repository/ShellRepository.java # backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java # backend/src/main/resources/db/changelog/db.changelog-master.yaml # backend/src/main/resources/db/changelog/db.changelog-v2.yaml # backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiSecurityTest.java # backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiTest.java # backend/src/test/java/org/eclipse/tractusx/semantics/registry/mapper/ShellMapperTest.java
…r-changes # Conflicts: # backend/src/main/java/org/eclipse/tractusx/semantics/registry/controller/AssetAdministrationShellApiDelegate.java # backend/src/test/java/org/eclipse/tractusx/semantics/registry/AssetAdministrationShellApiSecurityTest.java # backend/src/test/java/org/eclipse/tractusx/semantics/registry/TestUtil.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before merging, wait for the project content review: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9749 |
@SebastianBezold : do you have an update on this PR? |
Hi @tunacicek , from my point of view the PR is fine, but the project content review linked above is still open |
# Conflicts: # CHANGELOG.md
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Content review is done (approved): https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9749 |
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
Additional information
The PR is bigger than the expected 1000 lines because of new AAS 3.0 standard changes, which includes database changes and model changes.