[NEW model] early warning notification by Andreas & Timothy patch 1 #484

Timothy-Ra · 2023-11-27T09:25:05Z

Description

The new model enables the notification function about findings from joint field monitoring between two participants of the supply chain. This functionality is part of the early warning feature from the use case quality.

Closes #421

MS2 Criteria

(to be filled out by PR reviewer)

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

All required reviewers have approved this PR (see reviewers section)
The new aspect (version) will be implemented by at least one data provider
The new aspect (version) will be consumed by at least one data consumer
There exists valid test data
In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
The model has at least version '1.0.0'
If a previous model exists, model deprecation has been checked for previous model
The release date in the Release Note is set to the date of the MS3 approval

New model for early warning notification added

This file contains the new aspect structure for the early warning notification aspect.

agg3fe · 2023-11-27T13:03:52Z

@Timothy-Ra Did you create any Github issue for this Pull Request? If not, then please first create an issue here.After that we go for approval process.

updated model with respect to the MS2 criteria

add sample json content

agg3fe · 2024-01-18T09:47:10Z

io.catenax.early_warning_notification/1.0.0/metadata.json

@@ -0,0 +1,38 @@
+{


This file should only contain { "status" : "release"} . please delete the content of this file.

agg3fe · 2024-01-18T09:51:55Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix : <urn:samm:org.eclipse.examples:1.0.0#> .


please replace the org.eclipse.examples with io.catenax.early_warning_notification

agg3fe · 2024-01-18T10:32:17Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+
+:QualityAppFilter a samm:Entity ;
+   samm:preferredName "Affected Population FIlter"@en ;
+   samm:description "A set of filters and/or a list definieng the affected population"@en ;


typo definieng

agg3fe · 2024-01-18T10:32:43Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+:populationFilter a samm:Property ;
+   samm:preferredName "Population Filter"@en ;
+   samm:description "Filters on the common early warning data set to specify a population"@en ;
+   samm:characteristic :PopulationFilterCharateristic .


typo Charateristic

agg3fe · 2024-01-18T10:33:01Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+
+:uniqueIdentifiers a samm:Property ;
+   samm:preferredName "listOfSerialNumbers"@en ;
+   samm:description "List of unique identifiers to explicitly specifiy parts or vehicles exhibiting the issue described in the property \"anomalyDescription\""@en ;


typo specifiy

agg3fe · 2024-01-18T10:33:23Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+   samm:characteristic :UniqueIdentifiersCharacteristic .
+
+:PopulationFilterCharateristic a samm-c:List ;
+   samm:preferredName "Population Filter Charateristic"@en ;


typo Charateristic

agg3fe · 2024-01-18T10:33:48Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+
+:ValuesCharacteristic a samm-c:List ;
+   samm:preferredName "Values Characteristic"@en ;
+   samm:description "Caracteristic for the list of values"@en ;


typo Caracteristic

agg3fe · 2024-01-18T10:34:59Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+
+:qualityAppFilter a samm:Property ;
+   samm:preferredName "Quality App Filter"@en ;
+   samm:description "A filter to define the population of affected parts in a C-atnea-X quality app"@en ;


is C-atnea-X right?

agg3fe · 2024-01-18T10:39:50Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+   samm:characteristic :PopulationFilterCharateristic .
+
+:uniqueIdentifiers a samm:Property ;
+   samm:preferredName "listOfSerialNumbers"@en ;


preferredName should be plain english and not camel case.

agg3fe · 2024-01-18T10:43:55Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+:catenaXId a samm:Property ;
+   samm:preferredName "Catena-X ID"@en ;
+   samm:description "A unique identifier for a part or a vehicle. The identifier relates to a Catena-X digital twin"@en ;
+   samm:characteristic samm-c:Text ;


you can make use of shared aspect model (io.catenax.shared.uuid:1.0.0) for UUID.
you can refer this https://github.com/eclipse-tractusx/sldt-semantic-models/blob/a07bdd5b1515767d4f8d07deb47cf2a4aa728bef/io.catenax.quality_message_content/1.0.0/QualityMessageContent.ttl#L35C9-L35C17

@Timothy-Ra please check this also.

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

agg3fe

Please check my comments

accoridng to aspect model stuart

changed urn from example to specific io.catenax.early_warning_notification

accoring to feedback from aspect model stuart

model simplified

Timothy-Ra · 2024-01-29T16:07:05Z

Please check my comments

@agg3fe we changed the model according to your remarks and made some changes due to new infos on our side. Please check once again. Thank you :)

agg3fe · 2024-01-31T11:52:24Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

@@ -0,0 +1,158 @@
+#######################################################################
+# Copyright (c) 2022 Robert Bosch GmbH


please change the year to 2024

agg3fe · 2024-01-31T11:55:51Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix : <urn:samm:io.catenax.early_warning_notification:1.0.0#> .
+@prefix ext-header: <urn:samm:io.catenax.shared.message_header:1.0.0#> .


you can consider reference to new message header 2.0.0 as new version is released now. You might need to update your branch with main branch.

agg3fe · 2024-01-31T12:02:46Z

@Timothy-Ra please check my comments

github-actions · 2024-01-31T12:03:20Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

update accoring to updated notification header

Timothy-Ra · 2024-02-16T14:07:12Z

@Timothy-Ra please check my comments

@andreas-hutter and I updated according to your comments and some last minute changes from our side.

@agg3fe please validade

agg3fe · 2024-02-16T14:44:25Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+   samm:characteristic samm-c:Text ;
+   samm:exampleValue "3747429FGH382923974682" .
+
+:catenaXId a samm:Property ;


if this is a unique catenaXId, you can make use of shared aspect model Uuid.
example: https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.asset_tracker_links/2.0.0/AssetTrackerLinks.ttl#L38
please update your PR with main branch and use Uuid2.0.0 version instead of 1.0.0.

no, it´s not a catenaXId.

The VAN is the anomynized VIN (vehicle identification number). Which is the identifier for each individual car. You find it in the botton right corner of the wind shield of each car. Each OEM may uses another hash algorithm so that we musn´t define any further semantic limitations.

okay, i misunderstood, I changed it

github-actions · 2024-02-16T14:47:48Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

updated Catena-X ID reference

agg3fe

LGTM

github-actions · 2024-02-22T12:41:11Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Syntax error in line 125, column 24: Undefined prefix: ext-uuid

  120:    samm:exampleValue "3747429FGH382923974682" .
  121: 
  122: :catenaXId a samm:Property ;
  123:    samm:preferredName "Catena-X ID"@en ;
  124:    samm:description "A unique identifier for a part or a vehicle. The identifier relates to a Catena-X digital twin"@en ;
->125:    samm:characteristic ext-uuid:UuidV4Trait ;
  126:    samm:exampleValue "urn:uuid:ed85f17e-29dd-473c-9cb8-d7ad1dc44d2f" .
  127: 
  128: :serialPartNumber a samm:Property ;
  129:    samm:preferredName "Serial Part Number"@en ;
  130:    samm:description "A unique serial number for a produced part"@en ;

agg3fe · 2024-02-22T12:42:33Z

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

+@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
+@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
+@prefix : <urn:samm:io.catenax.early_warning_notification:1.0.0#> .
+@prefix ext-header: <urn:samm:io.catenax.shared.message_header:2.0.0#> .


you did not add the dependency for uuid here

agg3fe

please add dependency

agg3fe · 2024-02-23T14:06:53Z

Hi @Timothy-Ra, As I suggested above. please add the dependency which is missing. your model is invalid right now.

Added the requested reference to <urn:samm:io.catenax.shared.uuid:2.0.0> Deleted 3 properties that were actually not needed.

andreas-hutter · 2024-02-26T07:31:17Z

I have added the dependecy as requested (and removed 3 no longer needed properties). Can you please check the model validity again ?

github-actions · 2024-02-26T08:14:34Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

agg3fe

LGTM

agg3fe · 2024-02-26T08:26:05Z

@Timothy-Ra please check eclipsefdn/eca step https://api.eclipse.org/git/eca/status/gh/eclipse-tractusx/sldt-semantic-models/484.
It is giving error.

agg3fe · 2024-02-26T08:26:56Z

io.catenax.early_warning_notification/RELEASE_NOTES.md

+All notable changes to this model will be documented in this file.
+
+[Unreleased]
+[1.0.0] - 2023-12-11


please change it to today's date if you need MS3 today.

Updated date

github-actions · 2024-02-26T14:05:07Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

Converted notificationID characteristic to ext-uuid. Deleted unused dependency on share notification header.

Sorry, I had a copy paste error before.

github-actions · 2024-02-27T09:52:53Z

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

Timothy-Ra · 2024-02-27T10:46:09Z

thanks so much @agg3fe and @andreas-hutter for the great cooperation and that we finished that model :)

Timothy-Ra added 2 commits November 27, 2023 10:13

Create metadata.json

fc939c9

New model for early warning notification added

aspect model ttl file added

a494541

This file contains the new aspect structure for the early warning notification aspect.

Timothy-Ra changed the title ~~NEW model early warning notification by Andreas & Timothy patch 1~~ [NEW model] early warning notification by Andreas & Timothy patch 1 Dec 11, 2023

Timothy-Ra added 5 commits December 11, 2023 16:44

Create RELEASE_NOTES.md

c964e33

Update EarlyWarningNotification.ttl

715255f

updated model with respect to the MS2 criteria

Update metadata.json

4d64e06

add sample json content

Update metadata.json

497358f

Update EarlyWarningNotification.ttl

b5fac42

agg3fe reviewed Jan 18, 2024

View reviewed changes

io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl Show resolved Hide resolved

agg3fe requested changes Jan 18, 2024

View reviewed changes

Timothy-Ra added 4 commits January 29, 2024 16:21

Update metadata.json

6ff748b

accoridng to aspect model stuart

Update EarlyWarningNotification.ttl

1f40f4e

changed urn from example to specific io.catenax.early_warning_notification

Update EarlyWarningNotification.ttl

bc72b9d

accoring to feedback from aspect model stuart

Update EarlyWarningNotification.ttl

c788530

model simplified

agg3fe reviewed Jan 31, 2024

View reviewed changes

Update EarlyWarningNotification.ttl

aeba3bc

update accoring to updated notification header

agg3fe reviewed Feb 16, 2024

View reviewed changes

Update EarlyWarningNotification.ttl

6de476c

updated Catena-X ID reference

Timothy-Ra requested a review from agg3fe February 22, 2024 10:19

agg3fe approved these changes Feb 22, 2024

View reviewed changes

agg3fe reviewed Feb 22, 2024

View reviewed changes

agg3fe requested changes Feb 22, 2024

View reviewed changes

Timothy-Ra requested a review from agg3fe February 23, 2024 13:53

Update EarlyWarningNotification.ttl

8955ec0

Added the requested reference to <urn:samm:io.catenax.shared.uuid:2.0.0> Deleted 3 properties that were actually not needed.

agg3fe approved these changes Feb 26, 2024

View reviewed changes

agg3fe added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Feb 26, 2024

agg3fe reviewed Feb 26, 2024

View reviewed changes

Update RELEASE_NOTES.md

680463c

Updated date

agg3fe added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Feb 26, 2024

andreas-hutter added 2 commits February 26, 2024 15:55

Update EarlyWarningNotification.ttl

7abb4df

Converted notificationID characteristic to ext-uuid. Deleted unused dependency on share notification header.

Update EarlyWarningNotification.ttl

c687923

Sorry, I had a copy paste error before.

agg3fe merged commit 7af981a into eclipse-tractusx:main Feb 27, 2024
4 checks passed

		@@ -0,0 +1,158 @@
		#######################################################################
		# Copyright (c) 2022 Robert Bosch GmbH

[NEW model] early warning notification by Andreas & Timothy patch 1 #484

[NEW model] early warning notification by Andreas & Timothy patch 1 #484

Conversation

Timothy-Ra commented Nov 27, 2023 • edited by agg3fe Loading

Description

MS2 Criteria

MS3 Criteria

agg3fe commented Nov 27, 2023

Choose a reason for hiding this comment

agg3fe Jan 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agg3fe left a comment

Choose a reason for hiding this comment

Timothy-Ra commented Jan 29, 2024

Choose a reason for hiding this comment

agg3fe Jan 31, 2024 • edited Loading

Choose a reason for hiding this comment

agg3fe commented Jan 31, 2024

github-actions bot commented Jan 31, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

Timothy-Ra commented Feb 16, 2024

agg3fe Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 16, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

agg3fe left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 22, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Syntax error in line 125, column 24: Undefined prefix: ext-uuid

Choose a reason for hiding this comment

agg3fe left a comment

Choose a reason for hiding this comment

agg3fe commented Feb 23, 2024

andreas-hutter commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

agg3fe left a comment

Choose a reason for hiding this comment

agg3fe commented Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

github-actions bot commented Feb 27, 2024

Validation Report for io.catenax.early_warning_notification/1.0.0/EarlyWarningNotification.ttl

Input model is valid

Timothy-Ra commented Feb 27, 2024

Timothy-Ra commented Nov 27, 2023 •

edited by agg3fe

Loading

agg3fe Jan 18, 2024 •

edited

Loading

agg3fe Jan 31, 2024 •

edited

Loading

agg3fe Feb 16, 2024 •

edited

Loading

agg3fe commented Feb 26, 2024 •

edited

Loading