-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: Week Based Capacity Group 24.05 changes #590
[Model Update]: Week Based Capacity Group 24.05 changes #590
Conversation
@agg3fe updated external reference versions to 2.0.0 |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix one comment
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
All notable changes to this model will be documented in this file. | ||
|
||
## [3.0.0] - 2024-02-xx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change the date to 5th Feb if you want MS3 today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@agg3fe we have an open story where the property names of the SubHorizons entity could still be updated to make them more descriptive - i think we won't start the MS3 until next week |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
@dominikoeh i've heard that you're adding another extension of demand volatility to the aspect model. Will you please build on this latest PR here? |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
…name to RelativeNegativeDeviationTrait
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
@agg3fe PR ready for MS approval - the properties/entities under |
Validation Report for io.catenax.week_based_capacity_group/3.0.0/WeekBasedCapacityGroup.ttlInput model is valid |
Description
Changes on aspect model for DCM standard 24.05. Changes see RELEASE_NOTES.txt
Closes #565
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)