-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: Harmonize PlannedProductionOutput to industry core #601
[Model Update]: Harmonize PlannedProductionOutput to industry core #601
Conversation
Validation Report for io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttlInput model is valid |
Validation Report for io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttlInput model is valid |
io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the samm version
Validation Report for io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttlInput model is valid |
@tom-rm-meyer-ISST let me know about merge after changes. |
Validation Report for io.catenax.planned_production_output/2.0.0/PlannedProductionOutput.ttlInput model is valid |
@tom-rm-meyer-ISST can I merge it now? |
as discussed with @jacewski-bosch yesterday, the materialGlobalAssetId description already refers to PartType Twins. Thus, no change needed and ready to merge @agg3fe |
Description
-->
Closes #543
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)