-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: Harmonize DeliveryInformation to industry core #602
[Model Update]: Harmonize DeliveryInformation to industry core #602
Conversation
Validation Report for io.catenax.delivery_information/2.0.0/DeliveryInformation.ttlInput model is valid |
Validation Report for io.catenax.delivery_information/2.0.0/DeliveryInformation.ttlInput model is valid |
samm:exampleValue "2023-04-01T14:23:00+01:00"^^xsd:dateTime. | ||
:eventType a samm:Property; | ||
samm:preferredName "Event Type"@en; | ||
samm:description "Event type describes wether the mentioned timeOfEvent refers to a departure or arrival and provides the status of the delivery (estimated or actual)."@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo wether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.delivery_information/2.0.0/DeliveryInformation.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.delivery_information/2.0.0/DeliveryInformation.ttlInput model is valid |
@tom-rm-meyer-ISST let me know after changes |
Validation Report for io.catenax.delivery_information/2.0.0/DeliveryInformation.ttlInput model is valid |
@tom-rm-meyer-ISST ready for merge? |
as discussed with @jacewski-bosch yesterday, the materialGlobalAssetId description already refers to PartType Twins. Thus, no change needed and ready to merge @agg3fe |
Description
-->
Closes #544
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)