-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fleet.vehicles -> update of shared shared BPNS trait #629
Update fleet.vehicles -> update of shared shared BPNS trait #629
Conversation
Fix shared BPNS issue
@agg3fe Please check the updated model - only reference was changed |
Validation Report for io.catenax.fleet.vehicles/2.1.0/Vehicles.ttlInput model is valid |
Validation Report for io.catenax.fleet.vehicles/2.1.0/Vehicles.ttlInput model is valid |
@@ -0,0 +1,403 @@ | |||
####################################################################### | |||
# Copyright (c) 2022, 2024 Robert Bosch GmbH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022,2023, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @agg3fe I'm on vacation next week. I ask today, who from CX use case quality could proxy me on Monday's meeting. Change of model was discussed and agreed by CX quality use case team. In case I find nobody could you bring this to MS3 next week? |
samm:characteristic samm-c:Text ; | ||
samm:exampleValue "EA189" . | ||
|
||
:serialNumber a samm:Property ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partInstanceId
@jacewski-bosch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed date to MS3 date
Validation Report for io.catenax.fleet.vehicles/2.1.0/Vehicles.ttlInput model is valid |
Fix shared BPNS issue
Description
[2.1.0]
Added
Changed
Removed
Closes #626
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)