-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ShortTermMaterialDemand): added initial model #668
feat(ShortTermMaterialDemand): added initial model #668
Conversation
Validation Report for io.catenax.short_term_material_demand/1.0.0/ShortTermMaterialDemand.ttlValidation failed: |
@@ -0,0 +1,109 @@ | |||
####################################################################### | |||
# Copyright (c) 2023-2024 BASF SE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
:demand a samm:Property ; | ||
samm:preferredName "Demand"@en ; | ||
samm:description "uantity of materials required in the specified point in time according specified demand rate. This demand should be as close as possible to demand that is derived from the actual production program."@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo uantity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Validation Report for io.catenax.short_term_material_demand/1.0.0/ShortTermMaterialDemand.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.short_term_material_demand/1.0.0/ShortTermMaterialDemand.ttlInput model is valid |
Validation Report for io.catenax.short_term_material_demand/1.0.0/ShortTermMaterialDemand.ttlInput model is valid |
Description
-->
Closes #545
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)