-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model]: Repair certificate #687
Conversation
@agg3fe Please review once the recycling strategy is MS3 approved, Thanks |
Feature recycling strategy
Validation Report for io.catenax.shared.recycling_strategy_certificate/3.0.0/RecyclingStrategyCertificate.ttlInput model is valid |
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
@agg3fe updated |
# SPDX-License-Identifier: CC-BY-4.0 | ||
####################################################################### | ||
|
||
@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samm 2.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
@@ -3,7 +3,7 @@ All notable changes to this model will be documented in this file. | |||
|
|||
## [Unreleased] | |||
|
|||
## [3.0.0] - 2024-03-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to change date here for recycling strategy certificate.
This date is always the date when you get MS3 approval. Since this model is already MS3 approved and released, no changes required in this model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted back
|
||
## [Unreleased] | ||
|
||
## [1.0.0] - 2024-03-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here date change required to 11th march for MS3 approval on that day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tanweersalah please update the description of all certificates in a bit more specific way. |
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
Validation Report for io.catenax.repair_certificate/1.0.0/RepairCertificate.ttlInput model is valid |
Description
Model Description
The repair certificate marks the point in time or status update when one or several actions carried out to return a defective product or waste to a condition where it fulfils its intended use.
Issue : #573
-->
Closes #573
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)