docs(gov): clarify relationship between bom/usage models and cx-0045 #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agg3fe - is there anything missing here? |
Hi @arnoweiss, this looks fine from our side. I will merge this soon. Will let you know in case need more information. |
agg3fe
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check that domain experts and reviewers must ensure that new BoM and Usage Submodels must adhere to CX-0045. Usually, this would be a classic use-case for a shared aspect. However, the SAMM meta-model did not allow to add arbitrary properties which is why the fallback was to json-schema directly.