-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODEL_UPDATE] PCF for CX Rel. 24.08 #733
[MODEL_UPDATE] PCF for CX Rel. 24.08 #733
Conversation
Validation Report for io.catenax.pcf/7.0.0/Pcf.ttlInput model is valid |
Validation Report for io.catenax.pcf/7.0.0/Pcf.ttlInput model is valid |
@agg3fe : the update reflects the latest change requests as aligned with the PCF Use Case team and all relevant stakeholders, please consult the documentation in Confluence for details. Please review |
Validation Report for io.catenax.pcf/7.0.0/Pcf.ttlInput model is valid |
@SMaierTSI Does that mean, the Update complies to the Rulebook v3.0? In that case, maybe the descriptions and links should refer to v3.0 too, instead of v2.0? and also, shouldn't the references refer to the Catena-X Rulebook instead to the WBCSD? |
Validation Report for io.catenax.pcf/7.0.0/Pcf.ttlInput model is valid |
Validation Report for io.catenax.pcf/7.0.0/Pcf.ttlInput model is valid |
@jSchuetz88 Descriptions have been updated and refer to the PCF-Rulebook V3.0.0 now. Both Catena-X PCF-Rulebook and WBCSD specification are closely aligned, no need to change other references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the minor remarks, looks good to me.
Update of the PCF data model in context of CX Rel. 24.08
Description
-->
Closes #717
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)