Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one receiver displayed when investigation with multiple parts from different BPNs was created #827

Open
rogocof opened this issue Apr 4, 2024 · 2 comments
Labels
bug Something isn't working external Issues with external requestors quality_notification_improvement

Comments

@rogocof
Copy link

rogocof commented Apr 4, 2024

Links

Description

An Investigation which was started for multiple parts from different suppliers only shows one receiver in the UI and the API response payload.

Current behaviour

Only one receiver is named under "Send To BPN" in the UI. (See red mark on screenshot)
investigation_details
In database there are one entry for a new investigation and two entries for investigation_notifications created for this case. From database perspective the logic works fine. However the filter API for investigation returns an InvestigationResponse object which has a "sendTo" field with type String. The value for this field is mapped in the InvestegationResponseMapper class by taking the first notification and taking its "sendTo" value:
image

Expected behavior

A list of string is returned for the sendTo field is returned from the API and visualized in the UI because an Investigation can have multiple receivers.

Steps to reproduce the Bug

  1. Start a new investigation with 2 parts from different suppliers. multiple_parts
    description
    successfully_queued
  2. Open the queued investigation list. You see one investigation.
    investigation_list
  3. Click on the investigation to open the detail view:
    investigation_details
@mkanal
Copy link
Contributor

mkanal commented Apr 4, 2024

links to #774

@mkanal mkanal moved this from inbox to backlog in Trace-X Apr 4, 2024
@mkanal mkanal added bug Something isn't working external Issues with external requestors labels Apr 4, 2024
@ds-crehm
Copy link
Contributor

ds-crehm commented Jun 17, 2024

This was discussed in #774 and #849
The result of the dicsussion and the created concept is the following: When creating a notification with parts from multiple different suppliers, a separate notification will be created for each supplier. In a single notification, there will be no possibility to have multiple "sendTo" receivers anymore.
That will solve this issue and it will be implemented with the tickets #899 (backend) and #900 (frontend)

@mkanal mkanal removed the status in Trace-X Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Issues with external requestors quality_notification_improvement
Projects
Status: No status
Development

No branches or pull requests

3 participants