Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept: Notification Model #831

Closed
3 tasks
ds-mwesener opened this issue Apr 5, 2024 · 5 comments · Fixed by catenax-ng/tx-traceability-foss#1217
Closed
3 tasks

Concept: Notification Model #831

ds-mwesener opened this issue Apr 5, 2024 · 5 comments · Fixed by catenax-ng/tx-traceability-foss#1217
Assignees
@mkanal
Labels
concept issues describing to work on a concept

Comments

@ds-mwesener
Copy link
Contributor

ds-mwesener commented Apr 5, 2024 •
edited by mkanal
Loading

As ... ,
I want ... ,
so that ... .

Hints / Details

  • Currently, the attributes of a notification needs to be refactored.

Acceptance Criteria

  • Domain Model for Notification updated (TOBE)
  • Domain Model for NotificationMessage updated (TOBE)
  • Story for implementation has been created

Out of Scope

  • Implementation
@github-project-automation github-project-automation bot moved this to inbox in Trace-X Apr 5, 2024
@jzbmw jzbmw added the concept issues describing to work on a concept label Apr 16, 2024
@mkanal mkanal added the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Apr 23, 2024
@mkanal
Copy link
Contributor

mkanal commented Apr 23, 2024

@ds-mwesener scope is not clear. Discussion needed.

@ds-mmaul ds-mmaul changed the title Concept: Notification Model Notification Model Apr 30, 2024
@ds-mmaul ds-mmaul changed the title Notification Model Concept: Notification Model Apr 30, 2024
@ds-crehm ds-crehm mentioned this issue May 2, 2024
Closed
2 tasks
@ds-crehm
Copy link
Contributor

ds-crehm commented May 2, 2024 •
edited
Loading

Had a discussion with @ds-mwesener about the scope of this ticket.
Following changes to the data model are needed:

  • Remove unnecessary data fields
  • Make distinction between "notifications" and "messages" clear and remove/add fields to the correct object
  • Make error messages persistent (So they don't overwrite each other, whenever an error occurs)
  • Make status changes clear in the message object, so that the message history can be shown properly.

@ds-crehm ds-crehm removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label May 2, 2024
@ds-crehm ds-crehm moved this from inbox to wip in Trace-X May 7, 2024
@github-actions github-actions bot mentioned this issue May 7, 2024
Merged
@ds-crehm ds-crehm self-assigned this May 8, 2024
@ds-crehm
Copy link
Contributor

ds-crehm commented May 8, 2024

Not possible to test.
Ready for review.

@ds-crehm ds-crehm reopened this May 8, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm May 8, 2024
@ds-crehm ds-crehm moved this from wip to review in Trace-X May 8, 2024
@ds-lcapellino ds-lcapellino mentioned this issue May 8, 2024
Merged
2 tasks
ds-mwesener pushed a commit that referenced this issue May 8, 2024
@ds-crehm
chore(concept): #831 create concept
32930bf
ds-mwesener pushed a commit that referenced this issue May 8, 2024
@ds-crehm
chore(concept): #831 add changelog entry
df66493
ds-mwesener added a commit that referenced this issue May 8, 2024
@ds-mwesener
Merge pull request #1217 from catenax-ng/chore/831-notification-data-…
5e68f97 
…model

chore(concept): #831 create concept
@mkanal mkanal moved this from review to done in Trace-X May 13, 2024
@mkanal
Copy link
Contributor

mkanal commented May 13, 2024

PO acceptance in behalf of @jzbmw. Works as intended.

@mkanal mkanal closed this as completed May 13, 2024
@ds-crehm ds-crehm mentioned this issue May 14, 2024
Closed
4 tasks
@ds-crehm
Copy link
Contributor

Implementation story: #962

@mkanal mkanal mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
concept issues describing to work on a concept
Projects
Trace-X
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(concept): #831 create concept catenax-ng/tx-traceability-foss
4 participants
@jzbmw @mkanal @ds-mwesener @ds-crehm