-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Adjusted BPN validations on different operators #1456
Fix: Adjusted BPN validations on different operators #1456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: don't just change unrelated code, don't use final
except for field declarations
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
a82abc5
to
5e07cbf
Compare
9578e98
to
8a5aa9d
Compare
Thank you for the comments, I followed them and adjusted the code. |
please resolve conversations that you fixed, and then re-request the review |
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
…dation for isAllOf
…ght-hand operand empty
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
…and operand being empty
…son after searching for BPN
.../eclipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunction.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/validation/businesspartner/functions/BusinessPartnerGroupFunctionTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
WHAT
WHY
In order to keep the correct behavior on BPNL validations
FURTHER NOTES
Some minor adjusts reported by Sonar, including:
Closes ##1411
Closes ##775