feat(462): add war/jar timings and advise to exclude unchanged jars/wars #463
Conversation
Signed-off-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ActionImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ChangesImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ChangesImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ChangesImpl.java
Outdated
Show resolved
Hide resolved
- upgrade to Java 11 to use Duration instead of own computation - move code from the generic ActionImpl to ZipActionImpl - remove 'ms' unit from log because it's using HH:MM:SS Signed-off-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
jeanouii
changed the title
|
@bjhargrave How does it look now? |
| @@ -418,6 +433,25 @@ private void applyZipStream( | |||
| } | |||
| } | |||
|
|
|||
| private void printZipActionDuration(final String inputName) { | |||
| if (getLogger().isInfoEnabled()) { | |||
There was a problem hiding this comment.
ActionImpl reports this for DEBUG level logging and we should be consistent here.
There was a problem hiding this comment.
Yes I know, but that is exactly the purpose of the issue #462 and this PR.
Debug mode produces too much such as it's not usable and slows down the whole transformation process.
| } | ||
|
|
||
| private void printAdviseOnUnchanged(final String inputName) { | ||
| if (getLogger().isInfoEnabled() && !getActiveChanges().isChanged()) { |
There was a problem hiding this comment.
What is the value of this? I think we already report the number of changes in an element which may be zero thus providing this information.
Also, the advice is rather specific to a specific artifact when transformation rules should be more general to the domain. Updating the artifact to a later version without removing the advised exclusions can result in a partial transformation of the artifact if the excluded element in the newer artifact does indeed require transformation.
There was a problem hiding this comment.
This is a valid point. Of course if you change the rules, you should always run without any exclusions. But if you do iterations, or if you start converting some of your applications dependencies to jakarta, you can safely exclude them from the process.
Signed-off-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ZipActionImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
|
Creating new PRs because it seems it complains with the sign-off check |
No description provided.