Try to handle GOAWAY with a retry of the GET call falling back to Http/1 #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently some servers seem overloaded or unhappy with some requests when using Http/2, this adds a fallback to Http/1 if we detect GOAWAY and retry the request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some servers seem overloaded or unhappy with some requests when using Http/2, this adds a fallback to Http/1 if we detect GOAWAY and retry the request.
FYI @merks maybe we can use similar for the ECF implementaion, I was not yet able to see GOAWAY but it seems you was able to reproduce it somehow so maybe you want to give it a try?