fix #2877

[mlehmannm]

No description provided.

[laeubi]

We probably should move those constants to the TychoConstants class.

[mlehmannm]

I can do this in another PR. Would you backport this PR to 4.0.x first?

[laeubi]

Just add it to this pr no need for several ones. It would also be good to improve the commit message a bit (e.g. describe what is the problem and what was changed).

[mlehmannm]

Will do.

[laeubi]

Looks good, a testcase would be good to ensure this will not breakin the future.

[mlehmannm]

Looks good, a testcase would be good to ensure this will not breakin the future.

Where is a good place to add a testcase?

[laeubi]

@mlehmannm we have some integration test for the version plugin here:

https://github.com/eclipse-tycho/tycho/tree/master/tycho-its/src/test/java/org/eclipse/tycho/test/versionsplugin

[github-actions]

Test Results

   564 files  ±0     564 suites  ±0   5h 15m 17s ⏱️ + 27m 9s
   368 tests ±0     362 ✔️ +2    6 💤 ±0  0 ❌ ±0 
1 104 runs  ±0  1 085 ✔️ +3  19 💤 ±0  0 ❌ ±0 

Results for commit 1afc459. ± Comparison against base commit 69acea4.

♻️ This comment has been updated with latest results.

[mlehmannm]

Providing a testcase is really hard, because one would need a repository with at least an eclipse-plugin and the same eclipse-plugin as source with changes so that the baseline-mojo needs to increment the version of that eclipse-plugin.

[laeubi]

You might want to take a look at the BaselineMojoTest that creates a baseline repo first (you might even want to add your testcase there) and then modify the source sightly to generate a baseline error.

[mlehmannm]

I'll try to add a test to BaselineMojoTest next week.

[laeubi]

@mlehmannm whats the status here? I plan to publish a bugfix of Tycho4 soon and it seems good to have your fix included.

[mlehmannm]

Sorry for the delay. I was on vacation and had a busy week afterwards. I plan to provide a test for the fix, but it might take some time, but I think you can include that fix as it is mostly trivial.

[github-actions]

💚 All backports created successfully

Status	Branch	Result
✅	tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details