Move DependencyArtifacts computation into project types #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
laeubi
force-pushed
the
move_dependency_artifacts_into_project_types
branch
from
25d6bf6
to
a75c5b8
Compare
Test Results382 files ±0 382 suites ±0 2h 41m 30s ⏱️ + 17m 59s For more details on these errors, see this check. Results for commit 9367cc8. ± Comparison against base commit 2408842. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
move_dependency_artifacts_into_project_types
branch
4 times, most recently
from
ba1fb2c
to
144d75e
Compare
Currently DefaultTychoResolver computes the DependencyArtifacts on behalf of the TychoProject and then set these into the project using a context value, this has several drawbacks, e.g as it introduce ordering problem and we need to handle some things special for custom types. Instead the TychoProject itself should compute the dependencies on demand as its concrete implementation knows best how to compute these items and can simply do so on first request.
laeubi
force-pushed
the
move_dependency_artifacts_into_project_types
branch
from
144d75e
to
9367cc8
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DefaultTychoResolver computes the DependencyArtifacts on behalf of the TychoProject and then set these into the project using a context value, this has several drawbacks, e.g as it introduce ordering problem and we need to handle some things special for custom types.
Instead the TychoProject itself should compute the dependencies on demand as its concrete implementation knows best how to compute these items and can simply do so on first request.