Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #401 - Support nested targets #417

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Dec 6, 2021

This adds support for nested targets.

@laeubi laeubi added this to the 2.6 milestone Dec 6, 2021
@laeubi
Copy link
Member Author

laeubi commented Dec 6, 2021

FYI @vogella

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Unit Test Results

142 files  142 suites   38m 30s ⏱️
223 tests 220 ✔️ 3 💤 0

Results for commit 5311241.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Bananeweizen Bananeweizen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand most of the changes (due to my lacking knowledge, not because of the changes). Generally it looks okay to me.

</modules>

<properties>
<tycho-version>2.6.0-SNAPSHOT</tycho-version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still haven't understood why this is defined again and again in many ITs (and with older versions than 2.6 in some cases). Shouldn't all tests point to the current development version for testing (by inheriting from the root parent of tycho)? What am I missing there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tycho-version is overridden in the actual i-test run with the current build version so in that value is then irrelevant in this case as it is never used.
But if you are open the pom.xml in eclipse m2e of course complains that tycho-version is undefined and all kind of error markers are shown and code-completion does not work. Thus it is defined in (some but not all) of the itest mostly with the version that was recent at time of writing the test, it can always be adjusted to the latest version of course.

Just for convenience, it allows to right-click and Choose Run As > Maven install to test without a full itest run or specifying the version on the commandline.

Co-authored-by: Michael Keppler <bananeweizen@gmx.de>
@laeubi
Copy link
Member Author

laeubi commented Dec 8, 2021

I don't really understand most of the changes (due to my lacking knowledge, not because of the changes). Generally it looks okay to me.

Thanks for your suggestions, I had to refactor out an xml-lib tycho previously used to pare target files to move the parsing code to common location so don't mind it looks a bit crowded.

@laeubi laeubi merged commit 5311241 into eclipse-tycho:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants