-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #401 - Support nested targets #417
Conversation
FYI @vogella |
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand most of the changes (due to my lacking knowledge, not because of the changes). Generally it looks okay to me.
...cho.p2.resolver.impl/src/main/java/org/eclipse/tycho/p2/target/TargetDefinitionResolver.java
Outdated
Show resolved
Hide resolved
...cho.p2.resolver.impl/src/main/java/org/eclipse/tycho/p2/target/TargetDefinitionResolver.java
Outdated
Show resolved
Hide resolved
</modules> | ||
|
||
<properties> | ||
<tycho-version>2.6.0-SNAPSHOT</tycho-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still haven't understood why this is defined again and again in many ITs (and with older versions than 2.6 in some cases). Shouldn't all tests point to the current development version for testing (by inheriting from the root parent of tycho)? What am I missing there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tycho-version
is overridden in the actual i-test run with the current build version so in that value is then irrelevant in this case as it is never used.
But if you are open the pom.xml in eclipse m2e of course complains that tycho-version
is undefined and all kind of error markers are shown and code-completion does not work. Thus it is defined in (some but not all) of the itest mostly with the version that was recent at time of writing the test, it can always be adjusted to the latest version of course.
Just for convenience, it allows to right-click and Choose Run As > Maven
install to test without a full itest run or specifying the version on the commandline.
Co-authored-by: Michael Keppler <bananeweizen@gmx.de>
Thanks for your suggestions, I had to refactor out an xml-lib tycho previously used to pare target files to move the parsing code to common location so don't mind it looks a bit crowded. |
This adds support for nested targets.