Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IDependencyMetadata to a shared place #44

Merged
merged 6 commits into from
Apr 11, 2021
Merged

Move IDependencyMetadata to a shared place #44

merged 6 commits into from
Apr 11, 2021

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Apr 10, 2021

relates to #43

Signed-off-by: Christoph Läubrich laeubi@laeubi-soft.de

@laeubi
Move IDependencyMetadata to a shared place
9167e0b 
relates to #43

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Align method names
c1a775f 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Reactor project is actually an IDepdencyMetadata
a46499f 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Use enum to distinguish between different metadata types
a28050c 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Member Author

laeubi commented Apr 10, 2021

@mickaelistria any objections here?

@laeubi laeubi marked this pull request as ready for review April 10, 2021 08:58
@laeubi
Remove unrelated change
3f1f601 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
fix stream expression
8e15896 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
mickaelistria
mickaelistria approved these changes Apr 11, 2021
View reviewed changes
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good change. I particularly like the replacement of boolean primary by the more explicit SEED/RESOLVE enum and the other refactorings factorizing around IDependencyMetadata.

@laeubi laeubi merged commit af7f47c into eclipse-tycho:master Apr 11, 2021
@laeubi laeubi added this to the 2.4 milestone Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickaelistria mickaelistria mickaelistria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@laeubi @mickaelistria