Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove K3D and Dapr #10

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Remove K3D and Dapr #10

merged 6 commits into from
Apr 9, 2024

Conversation

BjoernAtBosch
Copy link
Member

@BjoernAtBosch BjoernAtBosch commented Apr 5, 2024 •
edited
Loading

Remove Dapr artefacts from velocitas_lib

Ticket #8

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

File Coverage Lines Branches
All files 68% 79% 56% ❌
velocitas_lib/__init__.py 47% 66% 28% ❌
velocitas_lib/docker.py 0% 0% 100% ❌
velocitas_lib/functional_interface.py 0% 0% 0% ❌
velocitas_lib/middleware.py 0% 0% 100% ❌
velocitas_lib/services.py 62% 76% 48% ❌
velocitas_lib/variables.py 95% 97% 93% ✅

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against de1eb03

@BjoernAtBosch BjoernAtBosch marked this pull request as ready for review April 5, 2024 11:31
BjoernAtBosch
BjoernAtBosch commented Apr 5, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
MP91
MP91 reviewed Apr 8, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
doosuu
doosuu previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pyproject.toml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ----------------------------------------
tests/test_services.py                      18       0  100.00%
tests/test_variables.py                     53       0  100.00%
tests/test_velocitas_lib.py                 69       0  100.00%
velocitas_lib/__init__.py                   45      15  66.67%   51-54, 75, 83, 98, 103, 116-118, 122-126
velocitas_lib/docker.py                     19      19  0.00%    15-116
velocitas_lib/functional_interface.py        9       9  0.00%    16-37
velocitas_lib/middleware.py                  5       5  0.00%    15-26
velocitas_lib/services.py                  114      27  76.32%   105, 108-123, 126, 174, 187-195, 204
velocitas_lib/variables.py                  37       1  97.30%   66
TOTAL                                      369      76  79.40%

Results for commit: 834ec70

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

doosuu
doosuu previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dennismeister93
dennismeister93 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BjoernAtBosch BjoernAtBosch merged commit df5339e into main Apr 9, 2024
5 checks passed
@BjoernAtBosch BjoernAtBosch deleted the remove_k3d_and_dapr branch April 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP91 MP91 MP91 left review comments

@dennismeister93 dennismeister93 dennismeister93 approved these changes

@doosuu doosuu doosuu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BjoernAtBosch @MP91 @dennismeister93 @doosuu