Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared folder from devcontainer-setup #12

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

dennismeister93
Copy link
Contributor

This PRs moves the content of the _shared folder from devenv-devcontainer-setup into velocitas-lib

Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93 dennismeister93 marked this pull request as draft June 9, 2024 06:04
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
@dennismeister93 dennismeister93 force-pushed the move-shared-from-devcontainer-setup branch from df78a64 to ba5f62b Compare June 9, 2024 06:29
@dennismeister93 dennismeister93 marked this pull request as ready for review June 9, 2024 06:37
velocitas_lib/conan_helper.py Outdated Show resolved Hide resolved
velocitas_lib/conan_helper.py Outdated Show resolved Hide resolved
dennismeister93 and others added 3 commits June 10, 2024 09:34
Co-authored-by: Markus Petke <MP91@users.noreply.github.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Signed-off-by: Dennis Meister <dennis.meister@bosch.com>
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dennismeister93 dennismeister93 merged commit 24ada01 into main Jun 10, 2024
5 checks passed
@dennismeister93 dennismeister93 deleted the move-shared-from-devcontainer-setup branch June 10, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants