Allow hot reloading of certs through KeyCertOptions #4519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Francisco Guerrero <francisco.guerrero@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we create servers with createHttpServer API we set server certs through server options. These options are set before starting server. When certificates are refreshed, already started HTTP server does not pick up refreshed certs. Hence we want to be able to enable hot reloading of certificates while setting certificate options in HttpServerOptions. By adding this feature, we will be able to refresh server certs without having to bounce the server.
Advantage of adding this feature
Reduces server downtime, by not needing a bounce when certs refresh.
Contribution
To do this, our thought process is to start a periodic timer to check for cert refreshes and the SSLContext is reloaded in case the certs have refreshed.